feat(api): report the display category on tile57_feature#14
Merged
Conversation
The engine knew each feature's S-52 display category — it gates on it via mariner.display_base/standard/other — but the vector surface dropped it when it built CFeature, so a host got cls/scamin/plane and no way to tell a display-base feature from a standard one. A host that applies SCAMIN itself (the surface path hands SCAMIN over deliberately: the category gate runs at GATE_ZOOM so SCAMIN always passes, and the host hides by zoom in a shader) cannot implement "SCAMIN shall not be applied to display base" without it. Add tile57_disp_cat (BASE/STANDARD/OTHER) and a disp_cat field carrying the baked cat, so the rule is one comparison on the host side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The engine knew each feature's S-52 display category — it gates on it via mariner.display_base/standard/other — but the vector surface dropped it when it built CFeature, so a host got cls/scamin/plane and no way to tell a display-base feature from a standard one.
A host that applies SCAMIN itself (the surface path hands SCAMIN over deliberately: the category gate runs at GATE_ZOOM so SCAMIN always passes, and the host hides by zoom in a shader) cannot implement "SCAMIN shall not be applied to display base" without it.
Add tile57_disp_cat (BASE/STANDARD/OTHER) and a disp_cat field carrying the baked cat, so the rule is one comparison on the host side.